Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Job options hidden1 #4472

Merged
merged 5 commits into from Feb 19, 2019
Merged

Job options hidden1 #4472

merged 5 commits into from Feb 19, 2019

Conversation

carlosrfranco
Copy link
Contributor

A new boolean flag should be added to the Option that defines if the option should be shown in the Job Run page.

job_options_hidden

@carlosrfranco
Copy link
Contributor Author

Created a validation for hidden options that must have a default value.

validate_hidden_options

gschueler
gschueler requested changes Feb 15, 2019
View reviewed changes
Copy link
Member

@gschueler gschueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of the boolean flag should be changed to just hidden

@gschueler gschueler added this to the 3.0.14 milestone Feb 19, 2019
@gschueler gschueler merged commit 3793ab0 into rundeck:master Feb 19, 2019
@gschueler gschueler mentioned this pull request Feb 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschueler gschueler gschueler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.14
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carlosrfranco @gschueler